Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): migrate all actions to one repo #1

Merged
merged 23 commits into from
Jan 5, 2025

Conversation

orubin
Copy link
Collaborator

@orubin orubin commented Dec 19, 2024

@maksadbek @bramkor
Updated URLs to match this repo.
Updated old key names to be new.
Updated eslint and prettier and package json to be in root folder.
Updated husky commit rules to be in root folder.

@orubin orubin requested review from maksadbek and bramkor December 19, 2024 09:43
@orubin orubin changed the title fix(actions): migrate all actions to one repo #code-review fix(actions): migrate all actions to one repo Dec 19, 2024
- Updated all actions to use node16 instead of node12
- Updated axios in wait-for action to fix CSRF vulnerability
- Rebuilt all actions to verify compatibility
- Updated all actions to use node20 instead of node16
- Updated GitHub Actions workflow to use Node.js 20
- Rebuilt all actions to verify compatibility
- Added HUSKY=0 environment variable to all jobs
- Prevents Husky from trying to install git hooks during CI
- Added --ignore-scripts flag to npm ci commands
- Prevents Husky and other prepare scripts from running during CI
- Changed all instances of ubuntu-latest to ubuntu-22.04
- Prevents future issues when ubuntu-latest moves to 24.04
- Added list-entrypoints action for retrieving project entrypoints
- Added wait-for-discovery action
- Updated root package.json to include new workspaces
- Centralized ESLint and Prettier configurations
- Add wait-for-discovery and list-entrypoints actions to release notes
- Update repository URL to point to bright-github-actions
- Update bugs and homepage URLs
- Remove prepare scripts with husky from list-entrypoints and wait-for-discovery
- Update package-lock.json
- Fix format scripts in wait-for-discovery
- Separate build and pack commands to match other packages
- Remove automatic pack after build
- Update lint-staged to ^15.2.0 in list-entrypoints
- Update other dependencies in list-entrypoints to match versions across packages
- Update package-lock.json
- Update is-ci to latest version in list-entrypoints and wait-for-discovery
- Update package-lock.json
- Update @types/node to ^20.10.8 in all packages
- Update @vercel/ncc to ^0.38.3 in all packages
- Fix ESLint version in list-entrypoints to be compatible with @typescript-eslint/parser
- Update package-lock.json
- Remove unused interfaces
- Fix TypeScript errors
- Improve code organization
- Fix lint issues
@maksadbek
Copy link
Contributor

  1. should we remove all nested package.json files and have one global ?
  2. should we remove the nested .github directories as well ?

@orubin
Copy link
Collaborator Author

orubin commented Jan 5, 2025

  1. should we remove all nested package.json files and have one global ?
  2. should we remove the nested .github directories as well ?

Thanks @maksadbek - currently i did not choose the way of a "native" / "standard" monorepo.
But chose the way of one repo to host all actions, and some shared files to save duplication.
I think that we can start this way and maybe later continue with organizing and refactoring.
For should we remove the nested .github directories as well ? - well no, they contain flows needed for testing and releasing the actions.

@maksadbek
Copy link
Contributor

Thanks, approved 👍

@maksadbek maksadbek merged commit 0a4eced into main Jan 5, 2025
10 checks passed
@orubin orubin deleted the all_actions_to_one_repo branch January 5, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants